openzeppelin-contracts icon indicating copy to clipboard operation
openzeppelin-contracts copied to clipboard

Use the inherited EIP712 name in the Governor contract

Open bcj-dev opened this issue 2 years ago • 2 comments

The Governor contract includes a {_name} state variable, but the parent EIP712 contract already uses and stores the exact same value. This is unnecessary duplicate storage.

This PR removes the duplicate {_name} state variable from the Governor, and in the Governor's public "name()" function, returns the result of the internal EIP712 function for retrieving the {_name} value.

PR Checklist

  • [ ] Tests
  • [ ] Documentation
  • [ ] Changeset entry (run npx changeset add)

bcj-dev avatar Nov 15 '23 09:11 bcj-dev

⚠️ No Changeset found

Latest commit: 4f484685586efb19e393c0a411666fddcb2c6a11

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Nov 15 '23 09:11 changeset-bot[bot]

This requires a bit more discussion because it may be a breaking change (it was in 4.x). Here's the context: https://github.com/OpenZeppelin/openzeppelin-contracts/issues/4214

ernestognw avatar Nov 16 '23 16:11 ernestognw