openzeppelin-contracts icon indicating copy to clipboard operation
openzeppelin-contracts copied to clipboard

✍️ IERC20: use `amount` instead of `value`

Open z0r0z opened this issue 3 years ago • 2 comments

✍️ use amount instead of value for event params to make match underlying functions

  • [x] Tests
  • [ ] Documentation
  • [ ] Changelog entry

z0r0z avatar Dec 08 '22 07:12 z0r0z

Hello @z0r0z

The EIP uses value and not amount. I agree that amount would have been a better choice of words, but so far we favored consistency with the EIP wording.

@frangio any opinion?

Amxx avatar Jan 04 '23 14:01 Amxx

I think this PR is pointing out that the events and the functions use a different word for the same concept. Perhaps we should use "value" instead of "amount", but I would agree that it should be consistent.

The ERC20 implementation uses "amount". Should we change it all to "value"?

frangio avatar Jan 13 '23 20:01 frangio

Closed by #4398

ernestognw avatar Jul 17 '23 18:07 ernestognw