openzeppelin-contracts icon indicating copy to clipboard operation
openzeppelin-contracts copied to clipboard

Add Strings.compare

Open 0xCaso opened this issue 3 years ago • 1 comments

Hi! I'd like to propose the addition of the new method compare for Strings, which would make things more elegant and make the code less repetitive. Also, it should be really useful for testing purposes with Foundry.

I'm referring to this (old) issue: https://github.com/OpenZeppelin/openzeppelin-contracts/issues/1795#issuecomment-1286701350

PR Checklist

  • [x] Tests
  • [x] Documentation
  • [x] Changelog entry

0xCaso avatar Oct 21 '22 09:10 0xCaso

Note: I'd love #3666 to be merge first, so that the tests can use the new syntax (instead of having to update #3666 yet again)

Amxx avatar Oct 26 '22 15:10 Amxx

What's the state of #3666? @Amxx

0xCaso avatar Dec 18 '22 17:12 0xCaso

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2022 OpenZeppelin Contracts Contributor:

GitPOAP: 2022 OpenZeppelin Contracts Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

gitpoap-bot[bot] avatar Dec 28 '22 21:12 gitpoap-bot[bot]