cairo-contracts icon indicating copy to clipboard operation
cairo-contracts copied to clipboard

feat: Add basic Multisig Account

Open TAdev0 opened this issue 1 year ago • 2 comments

Fixes #21

PR Checklist

  • [ ] Tests
  • [ ] Documentation
  • [ ] Added entry to CHANGELOG.md
  • [ ] Tried the feature on a public network

TAdev0 avatar Feb 23 '24 11:02 TAdev0

@martriay this is a first draft, only spent 2 hours on it.

Basically, i modified :

  • get_public_key for get_public_keys , returning a span of all public keys stored associated with the account
  • set_public_key for add_public_key and remove_public_key (with some checks missing for now)
  • _is_valid_signature now makes sure that all provided sig are valid

It is just a draft so you can tell me if the way i implemented it is relevant or not. Not that i added a threshold variable in storage, but did not implement for now a way to set it and modify it.

TAdev0 avatar Feb 23 '24 11:02 TAdev0

Thanks! Will look into it after we finish the current release.

martriay avatar Feb 27 '24 22:02 martriay

Hey @TAdev0, thanks for taking the time to contribute. Since we delayed this issue for a while, we worked on an implementation that will be included in this release. Feel free to jump into the conversation on #1193.

ericnordelo avatar Nov 07 '24 12:11 ericnordelo