difftest icon indicating copy to clipboard operation
difftest copied to clipboard

opt: dynamic set stack size of emu

Open Maxpicca-Li opened this issue 9 months ago • 2 comments

Solve PR 355 more elegantly.

Maxpicca-Li avatar Apr 26 '24 02:04 Maxpicca-Li

Thanks for the work. This PR looks good. However, I double check the progress of Verilator and find that it would be better to use the predicted stack size provided by Verilator. I'm proposing my ideas to Verilator in https://github.com/verilator/verilator/issues/4799.

If they accept to add the predictedStackSize method, we don't need this argument anymore. Otherwise, we can have this argument added.

poemonsense avatar Apr 26 '24 05:04 poemonsense

OK, that will be a better way to solve this.

Maxpicca-Li avatar Apr 26 '24 05:04 Maxpicca-Li

Our patch for Verilator has been accepted. Next release version of Verilator (v5.026) will come with a dynamic stack resizer using setrlimit. We've updated difftest to avoid explicit setrlimit in our own main() function in https://github.com/OpenXiangShan/difftest/pull/367. This PR is closed. Thanks all for this work.

poemonsense avatar May 09 '24 12:05 poemonsense