XiangShan icon indicating copy to clipboard operation
XiangShan copied to clipboard

Add the mill wrapper (millw)

Open Flowdalic opened this issue 10 months ago • 6 comments

To make the project easier to build add the mill wrapper (millw) submodule and make the mill executable selectable via the MILL Makefile variable. Furthermore, set ./millw as the default for the MILL Makefile variable, so that the wrapper is used as default.

Flowdalic avatar Apr 04 '24 12:04 Flowdalic

[Generated by IPC robot] commit: 09720f7219b888e625355a2e0478d18f8ee50d2e

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
09720f7 1.885 0.461 2.100 1.204 2.904 2.175 2.215 0.918 1.421 1.127 3.611 2.647 2.300 3.176

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
692e2fa
1d97d64 1.875 0.461 2.100 1.204 2.904 2.175 2.215 0.912 1.421 1.125 3.611 2.648 2.300 3.176
3953b70 1.885 0.461 2.100 1.194 2.904 2.181 2.218 0.919 1.421 1.124 3.611 2.660 2.300 3.176
4a8a734 1.885 0.461 2.100 1.204 2.904 2.175 2.215 0.918 1.421 1.125 3.611 2.647 2.300 3.176
5b0f002 1.875 0.461 2.100 1.203 2.904 2.180 1.395 0.912 1.421 1.127 3.611 2.659 2.300 3.176
6ade72d 1.885 0.461 2.100 1.194 2.904 2.175 1.395 0.918 1.398 1.125 3.611 2.648 2.300 3.176
672c464 1.885 0.461 2.100 1.199 2.904 2.175 1.396 0.912 1.398 1.125 3.611 2.647 2.300 3.176
321934c 1.885 0.461 2.100 1.194 2.904 2.175 1.396 0.919 1.421 1.125 3.611 2.659 2.300 3.176
4176c33 1.885 0.461 2.100 1.199 2.904 2.180 1.396 0.918 1.421 1.125 3.611 2.647 2.300 3.176
a5b77de 1.875 0.461 2.100 1.195 2.904 2.180 1.396 0.919 1.421 1.127 3.611 2.658 2.300 3.176

XiangShanRobot avatar Apr 07 '24 07:04 XiangShanRobot

We may first merge H extension to make things simpler.

Tang-Haojin avatar Apr 08 '24 08:04 Tang-Haojin

We prefer downloading mill(w) in Makefile to somewhere like ~/.cache/millw. Adding a new submodule may introduce more using and maintainance complexity.

Tang-Haojin avatar Apr 10 '24 01:04 Tang-Haojin

The mill wrapper is standalone. You don't have to use a submodule but could add the wrapper files directly. Alternatively, and probably more git-idiomatic, the millw repo could be added as git subtree (instead of a submodule).

Flowdalic avatar Apr 10 '24 05:04 Flowdalic

Chisel just updated the millw script by directly adding it to the git source: https://github.com/chipsalliance/chisel/pull/4119

poemonsense avatar Jun 01 '24 13:06 poemonsense

The mill wrapper is standalone. You don't have to use a submodule but could add the wrapper files directly. Alternatively, and probably more git-idiomatic, the millw repo could be added as git subtree (instead of a submodule).

Would you mind help us add millw as mill at the root directory of XiangShan? Or we can also do ourselves : )

Tang-Haojin avatar Jun 04 '24 07:06 Tang-Haojin