xbox-webapi-python icon indicating copy to clipboard operation
xbox-webapi-python copied to clipboard

Add support for microsoft-defined rate limits

Open jcxldn opened this issue 3 years ago • 0 comments

I think this is more of a proof-of-concept at the moment.

To-Do

  • [ ] Add 429 handling? Would it be worth logging/otherwise storing times when rate limited requests still have 429s? Would indicate where we would need to change things.

Docs

  • [x] Add docstrings (properly document everything)

Tests

  • [ ] Limits
    • [x] Burst only
    • [x] Sustain only (reaches burst multiple times, waits for it to reset)
    • [ ] Burst and sustain limits exceeded at the same time
    • [ ] A test with sufficient lifecycle where rate limits are reset

~~- [ ] Sorting and filtering~~

Testing python behaviour is probably not necessary.

jcxldn avatar Nov 15 '22 13:11 jcxldn