epanet-dev

epanet-dev copied to clipboard

As discussed briefly this week, here is one way of doing unit tests via cmake.

bradleyjeck

The water quality results of EPANET2 and EPANET3 are different.

3

I tested Net2.inp in the EPANET2 example file.

imksc

header-source API mismatch for EN_openOutputFile, EN_openReportFile

1

In epanet3.h, we have these two functions declared: int EN_openOutputFile(const char* fname, EN_Project p); int EN_openReportFile(const char* fname, EN_Project p); These do not seem to be defined, although in epanet3.cpp,...

jeffrey-newman

Debug versus Release Configurations for MSVC Compiler

5

The current instructions in the [README.md](https://github.com/OpenWaterAnalytics/epanet-dev/blob/master/README.md) file for building EPANET 3 using the Microsoft Visual C++ Build Tools creates a debug build of the project by default. Appending `/p:Configuration=Release` to...

LRossman

Conda packages

2

Hi @samhatchett, So I went and created some conda packages for epanet-dev for you guys to try and see more or less what that approach implies. I added [two small...

goanpeca

enable library user to construct network programmatically

3

This is a needed feature of the library that would make it appealing for many uses - commercial and research. Rather than depending on the `inp` format, client code should...

samhatchett

Need general results/reporting ability

27

I think I share this need with @ttaxon - we would like to be able to reproduce the epanet-2 style binary file (which contains results from each hydraulic step, not...

samhatchett

Need contribution guide

5

Should have a section in README about the GitHub Flow model and specific guidelines about how collaboration, branching, and PRs work for this project. Anybody want to volunteer some language?

samhatchett

For owned or transferred pointers, we should be using `std::unique_ptr` for RAII and memory management. Especially in context of exception handling and potentially returning `new` allocations to client code which...

samhatchett

Thanks to @bradleyjeck [guide](https://github.com/OpenWaterAnalytics/epanet-dev/blob/master/README.md#windows--visual-studio) I was able to compile the dll on Windows using CMake 3.6.1 and the Visual Studio 2015 Community edition. However, I'm not sure what exactly is...

eladsal