ovos-core
ovos-core copied to clipboard
[BUG] all fallback answer
Describe the bug If you install skill-ovos-fallback-chatgpt along another fallback skill, both fallback will answer
To Reproduce Steps to reproduce the behavior:
- Install skill-ovos-fallback-unknown
- Install skill-ovos-fallback-chatgpt
- Ask something weird (it happen a lot when not using English)
- Both fallback skills answer
Expected behavior The first fallback that answer should close the dialogue.
Additional context Chatgpt takes a long time to answer, this causes a time out and makes fallback service go to next skill, but the fallback that timed out is not stopped
Will look into this issue. as it might be related to; https://github.com/OpenVoiceOS/ovos-core/issues/383
It seems more an issue with the timeout I think, I will try to find the reference in the matrix chat, we discussed this once with @JarbasAl
with latest gpt skill this should be fixed
@JarbasAl Fixed? Can we close?
not fixed, a older chatgpt skill exposes the issue
if a fallback takes too long to answer core goes to the next one assuming it crashes, so very slow fallbacks will still trigger, after another one has been selected
its not all fallbacks answering, its a fallback timing out and still executing at a later point