ovos-core icon indicating copy to clipboard operation
ovos-core copied to clipboard

[BUG] all fallback answer

Open denics opened this issue 2 years ago • 5 comments

Describe the bug If you install skill-ovos-fallback-chatgpt along another fallback skill, both fallback will answer

To Reproduce Steps to reproduce the behavior:

  1. Install skill-ovos-fallback-unknown
  2. Install skill-ovos-fallback-chatgpt
  3. Ask something weird (it happen a lot when not using English)
  4. Both fallback skills answer

Expected behavior The first fallback that answer should close the dialogue.

Additional context Chatgpt takes a long time to answer, this causes a time out and makes fallback service go to next skill, but the fallback that timed out is not stopped

denics avatar May 23 '23 20:05 denics

Will look into this issue. as it might be related to; https://github.com/OpenVoiceOS/ovos-core/issues/383

j1nx avatar Dec 29 '23 08:12 j1nx

It seems more an issue with the timeout I think, I will try to find the reference in the matrix chat, we discussed this once with @JarbasAl

denics avatar Dec 30 '23 11:12 denics

with latest gpt skill this should be fixed

JarbasAl avatar Dec 30 '23 15:12 JarbasAl

@JarbasAl Fixed? Can we close?

mikejgray avatar Jan 18 '24 00:01 mikejgray

not fixed, a older chatgpt skill exposes the issue

if a fallback takes too long to answer core goes to the next one assuming it crashes, so very slow fallbacks will still trigger, after another one has been selected

its not all fallbacks answering, its a fallback timing out and still executing at a later point

JarbasAl avatar Jan 18 '24 01:01 JarbasAl