SVT-HEVC icon indicating copy to clipboard operation
SVT-HEVC copied to clipboard

Cleanup: Convert tabs to spaces and remove trailing spaces

Open 1480c1 opened this issue 4 years ago • 9 comments

WIll the patches be okay with the conversion of whitespaces? Mainly about the hashes

Also modified STYLE.md's sed to exclude .git, build,Bin, and png and added a command to append newlines to files if it doesn't have it. I checked the encoder guide and the pictures seem to not be corrupt

1480c1 avatar Aug 06 '19 01:08 1480c1

The style job now passes for tabs, carriage returns, and spaces and final newlines

Should we enforce that now?

1480c1 avatar Aug 06 '19 02:08 1480c1

@1480c1 Thank you for taking the effort to fix the coding style. We intentionally postpone coding style clean up to avoid rebasing of #70. Once it is merge, could you perform clean up again? Thanks.

tianjunwork avatar Aug 06 '19 02:08 tianjunwork

Sure!

1480c1 avatar Aug 06 '19 02:08 1480c1

Can this be updated as it is the remaining PR item for the 1.4 release and now is a good time to make these changes? There was another PR for cleanup (226) that is a bit older and can be withdrawn.

intelmark avatar Aug 08 '19 18:08 intelmark

I have excluded all of the files in #70

1480c1 avatar Aug 26 '19 20:08 1480c1

Hi Chris, PR70 will soon be merged hopefully. It is still preferable to include it for style conversion.

tianjunwork avatar Aug 26 '19 20:08 tianjunwork

I can open another PR with files specifically from 70 after it's merged, or would it be preferable to just merge style changes in one commit?

1480c1 avatar Aug 26 '19 20:08 1480c1

Either is fine. Whatever you think can reduce your effort:)

tianjunwork avatar Aug 26 '19 21:08 tianjunwork

I can wait, main reason why I wish to merge this is so that in the future my pr's don't include so much whitespace changes

1480c1 avatar Aug 26 '19 21:08 1480c1