openvidu icon indicating copy to clipboard operation
openvidu copied to clipboard

Remove console outputs from openvidu-node-client package

Open daniyel opened this issue 4 years ago • 2 comments

Describe the bug It would be nice, if you could remove all the console outputs from openvidu-node-client package. I am using it in my Node.js backend and I get really long outputs when error occurs and I cannot control the output especially in Session.ts (here), whole object Writable gets printed out in terminal (i had to set my VS Code terminal to 15000 lines so I could see whole error). It would be nice, if all this console calls could be removed from the package. It would be also nice to not set the whole error.request in Error, since Error expects string as an argument and error.request is object. In my case I can see after I go through whole error.request that I get error authorizationError: 'DEPTH_ZERO_SELF_SIGNED_CERT', maybe that could be somehow extracted and set as an throw new Error('DEPTH_ZERO_SELF_SIGNED_CERT') instead?

Expected behavior No console output coming from openvidu-node-client package.

daniyel avatar Apr 09 '20 19:04 daniyel

Thank you for the suggestions.

micaelgallego avatar Apr 09 '20 23:04 micaelgallego

Good suggestion. If possible, create a var debug = true/false on init

lwen3 avatar Apr 14 '20 19:04 lwen3