tap-windows6 icon indicating copy to clipboard operation
tap-windows6 copied to clipboard

Published 20 hours ago • verified publisher icon OpenVPN

Update buildtap.py

Open peergine-admin opened this issue 5 years ago • 3 comments

peergine-admin avatar Mar 06 '20 09:03 peergine-admin

@peergine-admin can you explain why this is useful/needed?

mattock avatar Mar 06 '20 10:03 mattock

When the non-default language is English type windows operation runtime, for example, the default character set of Chinese Windows operating system is GBK. Stupid python will report an error here. UnicodeDecodeError: 'gbk' codec can't decode byte 0xbf in position 2: illegal multibyte sequence

peergine-admin avatar Mar 06 '20 10:03 peergine-admin

@peergine-admin ok, I see. This does, however, break appveyor builds:

***** BUILD TAP config
Traceback (most recent call last):
  File "buildtap.py", line 511, in <module>
    btw.build()
  File "buildtap.py", line 280, in build
    self.build_tap()
  File "buildtap.py", line 255, in build_tap
    self.config_tap()
  File "buildtap.py", line 197, in config_tap
    self.preprocess(kv, os.path.join(self.src, "OemVista.inf"))
  File "buildtap.py", line 189, in preprocess
    with open(in_path+'.in', encoding='utf_8_sig') as f:
TypeError: 'encoding' is an invalid keyword argument for this function

Can you check what might be causing this?

mattock avatar Mar 06 '20 12:03 mattock