openvpn icon indicating copy to clipboard operation
openvpn copied to clipboard

Pass environment needed for systemd-ask-pass

Open Firstyear opened this issue 1 year ago • 1 comments

systemd-ask-pass allows the pin to be provided by the systemd-credentials mechanism, but that requires the environment variable $CREDENTIALS_DIRECTORY to be set. Openvpn when launched by systemd does have this environment variable available, but it doesn't pass it through to systemd-ask-pass meaning that systemd-ask-pass is unable to load the pin from systemd-credentials.

This change passes the $CREDENTIALS_DIRECTORY environment variable to the execed systemd-ask-pass invocation so that systemd-credentials can be used for non-interactive pin entry.

Thank you for your contribution

You are welcome to open PR, but they are used for discussion only. All patches must eventually go to the openvpn-devel mailing list for review:

  • https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Please send your patch using git-send-email. For example to send your latest commit to the list:

$ git send-email [email protected] HEAD~1

For details, see these Wiki articles:

  • https://community.openvpn.net/openvpn/wiki/DeveloperDocumentation
  • https://community.openvpn.net/openvpn/wiki/Contributing

Firstyear avatar Oct 22 '24 02:10 Firstyear

I won't be able to submit this to a mailing list, as I don't have a git email work flow setup. Feel free to send this on my behalf.

Firstyear avatar Oct 22 '24 02:10 Firstyear