openvpn-build icon indicating copy to clipboard operation
openvpn-build copied to clipboard

Published 20 hours ago • verified publisher icon OpenVPN

Add CRCCheck and ManifestDPIAware

Open ikreb7 opened this issue 4 years ago • 5 comments

  • add CRCCheck (see [1])
  • add ManifestDPIAware (see [2])

For ManifestDPIAware are at least nsis3 necessary.

ikreb7 avatar Mar 16 '20 14:03 ikreb7

What is your opinion to this PR?

ikreb7 avatar Mar 30 '20 10:03 ikreb7

@ikreb7 did you see my earlier comments? Or was this one of the cases where my in-line comments were lost...

mattock avatar Apr 16 '20 16:04 mattock

Thanks for your feedback. I hope I answered all comments understandable.

ikreb7 avatar Apr 16 '20 18:04 ikreb7

I will have a look tomorrow

chipitsine avatar Apr 17 '20 15:04 chipitsine

What is with this PR?

ikreb7 avatar Aug 15 '20 11:08 ikreb7

We have decided to remove the nsis/mingw buildsystem since it is not maintained anymore. Only the msi/msvc buildsystem will remain, unless someone steps up to maintain the other parts. This issue will be closed when the removal actually happens.

flichtenheld avatar Dec 14 '22 13:12 flichtenheld

nsis build is not supported anymore.

flichtenheld avatar Jul 07 '23 13:07 flichtenheld