OpenTracks icon indicating copy to clipboard operation
OpenTracks copied to clipboard

fix(api,service): from intent api, launch record service on foreground

Open abdoulayeYATERA opened this issue 1 year ago • 7 comments

Fixes : https://github.com/OpenTracksApp/OpenTracks/issues/1904 As record service uses foreground notification, replaces the launch of the the record service from intent api.

Uses

executeForeground

Instead of

execute

Please review and ajust (if needed) before merge, as my knowledge of the code base is close to null for now.

Thanks.

abdoulayeYATERA avatar Sep 25 '24 15:09 abdoulayeYATERA

We've been discussing this in https://github.com/hbldh/bleak/issues/1621.

My preference would be to move this to a separate function in addition to adding the require permissions for newer Android versions.

dlech avatar Oct 02 '24 00:10 dlech

We've been discussing this in #1621.

My preference would be to move this to a separate function in addition to adding the require permissions for newer Android versions.

done

tomaszduda23 avatar Oct 02 '24 08:10 tomaszduda23

Also, we will need a changelog entry explaining that this is a breaking change.

dlech avatar Oct 05 '24 15:10 dlech

updated according to review notes

tomaszduda23 avatar Oct 13 '24 11:10 tomaszduda23

github action should have started itself after pushing new version. It takes way to much time to fix all lint.

tomaszduda23 avatar Oct 17 '24 19:10 tomaszduda23

Don't worry about the linting, I can fix it when I get back to this.

dlech avatar Oct 17 '24 20:10 dlech

any chance to get it merged?

tomaszduda23 avatar Feb 01 '25 16:02 tomaszduda23