engine icon indicating copy to clipboard operation
engine copied to clipboard

Confusing error message with wrongly formatted history files

Open zenobioarn opened this issue 5 months ago • 0 comments

What I was trying to do

  • Implement Pinterest history file, see https://github.com/OpenTermsArchive/pga-declarations/pull/456

What happened

  • All checks failed with error "serviceHistory(termsType) push is not a function", see https://github.com/OpenTermsArchive/pga-declarations/pull/456/checks

What I was hoping to see happen instead

  • Checks failed with a useful error such as "History file is not properly formatted, it is missing an array in the terms history".

Additional information

I am sure this is only related to formatting, as the follow-up PR https://github.com/OpenTermsArchive/pga-declarations/pull/461 with corrected formatting passed all checks.

Addition notes

As you can see here https://github.com/OpenTermsArchive/pga-declarations/pull/456, it was solved already by @MattiSG, so it is not urgent to fix a declaration, but you might want to be aware of this for the next times.

zenobioarn avatar Aug 06 '25 13:08 zenobioarn