nml icon indicating copy to clipboard operation
nml copied to clipboard

Codechange: Vendor in latest ply version

Open glx22 opened this issue 1 year ago • 4 comments

According to https://github.com/dabeaz/ply/blob/master/CHANGES, the latest version will never be available via pip, and the preferred way to use ply is to vendor it. Latest ply version removes caching of lexer/parser tables, and as a side effect fixes #332.

glx22 avatar Oct 14 '24 14:10 glx22

Given it removes commandline options, this feels like more than just a "Codechange"

LordAro avatar Oct 14 '24 14:10 LordAro

FWIW I added the use of caching in #63 and in hindsight it was clearly a mistake. The speedup was quite noticeable on the very slow laptop I had at the time, but is negligible on modern PCs.

FLHerne avatar Jan 02 '25 10:01 FLHerne

Is this planned for merging any time soon? I'm unable to auto-build my newGRF using Github workflows without it (or finding another solution) so it would be good to know whether I need to find an alternative

audigex avatar Feb 15 '25 20:02 audigex

Is this planned for merging any time soon? I'm unable to auto-build my newGRF using Github workflows without it (or finding another solution) so it would be good to know whether I need to find an alternative

#362 should already fix your build issue I think

glx22 avatar Feb 15 '25 20:02 glx22