nml icon indicating copy to clipboard operation
nml copied to clipboard

WIP: handle labels more readably

Open FLHerne opened this issue 5 years ago • 2 comments

Unfinished, but does this look sane?

See changes in regression/expected.

FLHerne avatar Oct 31 '20 19:10 FLHerne

Changes in regression/expected are correct. I like how ASCII values are printed, but full numerical values looked better with dxXXXXXXXX

glx22 avatar Nov 01 '20 02:11 glx22

Changes in regression/expected are correct. I like how ASCII values are printed, but full numerical values looked better with dxXXXXXXXX

You mean the ones like "\12\34\56\78"? That's where the input NML happened to use all escaped bytes in a string-literal, e.g. in this case

// also override some other grf, this time not setting our own grfid explicitly
engine_override("\12\34\56\78");

I think this is probably helpful because it makes it clearer where the value came from, and that adding some heuristic would be confusing.

This should never affect numeric values that weren't strings in the source code.

FLHerne avatar Nov 01 '20 09:11 FLHerne