winery icon indicating copy to clipboard operation
winery copied to clipboard

Published 20 hours ago • verified publisher icon OpenTOSCA

[WIP] Feature/properties in boundary definitions

Open v-yussupov opened this issue 6 years ago • 4 comments

Add Property Definitions for Properties in Boundary Defintions

With this feature, Properties in Boundary Defintions, in addition to the original plain XML specification, can be specified using a PropertyDefintions extension element that is defined on the level of ServiceTemplate.

What's added:

  • Properties Definition tab on the level of ServiceTemplate (similar to Node Types, etc)

  • Apart from Winery's KV proeprties, specification of XML elements/types is also possible

  • Properties are instantiated based on the specified Properties Definition

  • If no Properties Definition was specified, properties can be specified as in the original implementation

  • If existing Properties Definition are removed or their type is changed, e.g., from XML element to KV properties, specified properties and property mappings are also removed

  • Changes of KV Properties Definition (adding or removing new kv pairs) is reflected in both, properties and property mappings

  • Property Mappings now have a select element allowing to choose defined KV properties (in case KV properties were used in Properties Definition), otherwise an original input field is kept

  • [ ] Ensure that you followed http://eclipse.github.io/winery/dev/ToolChain#github---prepare-pull-request. Especially, we require a single commit

  • [x] Ensure that the commit message is a good commit message

  • [ ] Ensure to use auto format in all files

  • [ ] Ensure that you appear in NOTICE at Copyright Holders

  • [ ] Tests created for changes

  • [ ] Documentation updated (if needed)

  • [ ] Screenshots added (for UI changes)

v-yussupov avatar Aug 03 '18 13:08 v-yussupov

I generated a structure-diff below from pulling c2f8beb on OpenTOSCA:feature/issue-199 into e34186c on OpenTOSCA:master.

Structure Diff

clarity-bot[bot] avatar Aug 03 '18 13:08 clarity-bot[bot]

Hi @v-yussupov, what needs to be done here for the final merge?

miwurster avatar Nov 22 '19 10:11 miwurster

@miwurster actually, I'm not sure if it's still needed. I think initially Lukas planned to have this feature for the paper, but eventually it was not used. @lharzenetter, is it still needed?

v-yussupov avatar Nov 22 '19 10:11 v-yussupov

@lharzenetter please revise, finalize and merge this PR ... otherwise, close it.

miwurster avatar Feb 14 '20 05:02 miwurster