GP2040-CE icon indicating copy to clipboard operation
GP2040-CE copied to clipboard

Github White Spaces Turned Off?

Open arntsonl opened this issue 11 months ago • 2 comments

Developer Issue:

Github white spaces was turned off it looks like. This is a developer note, we need to make sure white spaces is correct so we do not have check-ins with tabs, 2 white spaces, 4 white spaces, etc.

arntsonl avatar Mar 19 '24 23:03 arntsonl

Not sure this is something new, when doing FE changes i've converted most white spaces/indentation to adhere to https://github.com/OpenStickCommunity/GP2040-CE/blob/main/.editorconfig using prettier, unsure what other devs are using.

We added .gitattributes for line endings but this should not affect white spaces/indentation. https://github.com/OpenStickCommunity/GP2040-CE/blob/main/.gitattributes

I've seen some (old) files that are using mixed like: https://github.com/OpenStickCommunity/GP2040-CE/blob/main/www/src/Pages/SettingsPage.jsx

At least for the web config we could have a linter as build step, been hesitant to add that thought.

Pelsin avatar Mar 20 '24 09:03 Pelsin

I dropped the link yesterday but I would recommend having a ./.clang-format and having VScode, vim, etc. use that to enforce linting. Seems like the best common tool I've seen around.

bsstephan avatar Mar 22 '24 16:03 bsstephan

I'm going to close this as this isn't something we can just "enable" in github

arntsonl avatar Jun 03 '24 15:06 arntsonl