OpenSourceHelpCommunity.github.io icon indicating copy to clipboard operation
OpenSourceHelpCommunity.github.io copied to clipboard

Separate settings file for dev, predev and production

Open tapaswenipathak opened this issue 7 years ago • 8 comments

Currently we have one settings file running for all the deployments. Few important changes required our :

  1. Debug should be false for all but predev.
  2. Secret key should not be exposed.

tapaswenipathak avatar Oct 20 '17 11:10 tapaswenipathak

I could work on this if no one took this up already.

amakarudze avatar Oct 20 '17 22:10 amakarudze

@amakarudze sure!! You can take this issue

vaibhavsingh97 avatar Oct 20 '17 23:10 vaibhavsingh97

@amakarudze Any updates?

anubhakushwaha avatar Dec 12 '17 07:12 anubhakushwaha

I have done 2 separate pull requests I am failing to merge to make one. Am not sure how to do that unfortunately. Am not that experienced with git.

On Dec 12, 2017 09:18, "Anubha Kushwaha" [email protected] wrote:

@amakarudze https://github.com/amakarudze Any updates?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OpenSourceHelpCommunity/OpenSourceHelpCommunity.github.io/issues/164#issuecomment-350965896, or mute the thread https://github.com/notifications/unsubscribe-auth/AM9qxcfbaCsCNpp_9bzdoarZp3XvTzZ6ks5s_ijcgaJpZM4QAjTw .

amakarudze avatar Dec 12 '17 08:12 amakarudze

@amakarudze Please let us know your problem and maybe we can help you :)

anubhakushwaha avatar Dec 12 '17 14:12 anubhakushwaha

@amakarudze The easiest way is to close those pull request and then create new with your changes.

tapaswenipathak avatar Dec 15 '17 14:12 tapaswenipathak

Alright. Noted with thanks. Let me do so.

On Dec 15, 2017 16:26, "Tapasweni Pathak" [email protected] wrote:

@amakarudze https://github.com/amakarudze The easiest way is to close those pull request and then create new with your changes.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OpenSourceHelpCommunity/OpenSourceHelpCommunity.github.io/issues/164#issuecomment-352018361, or mute the thread https://github.com/notifications/unsubscribe-auth/AM9qxS87CleSperwTk3YoPLgGMjRzlwyks5tAoGPgaJpZM4QAjTw .

amakarudze avatar Dec 15 '17 15:12 amakarudze

I have followed Tapasweni's advice and closed the pull requests and created another one.

Should I worry about hound checks which do not recognize from base import *?

On 12 December 2017 at 16:56, Anubha Kushwaha [email protected] wrote:

@amakarudze https://github.com/amakarudze Please let us know your problem and maybe we can help you :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OpenSourceHelpCommunity/OpenSourceHelpCommunity.github.io/issues/164#issuecomment-351075164, or mute the thread https://github.com/notifications/unsubscribe-auth/AM9qxTolUwqgme27NU6sACVl87S6P903ks5s_pQJgaJpZM4QAjTw .

amakarudze avatar Dec 15 '17 20:12 amakarudze