Molecule icon indicating copy to clipboard operation
Molecule copied to clipboard

Integration of new visualization options

Open Eliott-Guevel opened this issue 11 months ago • 2 comments

Eliott-Guevel avatar Mar 25 '24 10:03 Eliott-Guevel

@Eliott-Guevel I found a problem in this panel: image

From the state of the screenshot (two selected elements): 1 - I click on "Browse" the class Equipment is browsed. 2 - I click on Receiver in the required list, and I click on "Browse" the class Equipment is always browsed

labordep avatar Mar 26 '24 15:03 labordep

see #172 for a fix

Eliott-Guevel avatar Mar 27 '24 08:03 Eliott-Guevel

Hi @Eliott-Guevel why this PR is not yet merged?

labordep avatar Jun 14 '24 13:06 labordep

image I don't know if GitHub also shows you this message, but I fixed my code according to your comments so you can merge this pull request since the interfaces function as intended and are named correctly. Thanks

Eliott-Guevel avatar Jun 25 '24 07:06 Eliott-Guevel

Hi @Eliott-Guevel, the PR #177 is now merged. This PR contains new components start/stop announcement system. You can test your dev with it. Some tests for P12 are not passing, please check that (ignore P13 tests). Thanks!

labordep avatar Jun 25 '24 14:06 labordep

There are no problems with my interfaces using the new main branch with #177 merged.

However, I don't understand why some of MolComponentManager's tests fail sometimes. When executing all of MolComponentManager's tests at the same time, 3 (or less) tests can fail (always the same ones, see Pharo 12 CI as well as testGarbageCollect (don't know why testFlushComponent is executed 2 times), which is not the case when executing them individually. Putting relevant variables and going line by line in the debugger isn't useful to identify the fail (doesn't lead to the same result). My guess is that since the order of tests is random, there's sometimes a bug with cleanUp and not all components are cleaned or something of the sort (and ONLY in Pharo 12, so could abso be a problem with the VM which apparently it is not, see https://github.com/pharo-project/pharo/issues/16808#issuecomment-2191257456).

Eliott-Guevel avatar Jun 26 '24 07:06 Eliott-Guevel

I have no problem using the visualization option (which isn't currently intergrated to Molecule) with #177, it could be merged in the near future

Eliott-Guevel avatar Jul 02 '24 07:07 Eliott-Guevel