OpenSmalltalk
Repair linux64x64 compilation
Hello Eliot et al.,
I produced these commits to get Cog building on Debian sid/trixie from current git Cog branch. The number of faults suggested to me that I was holding it wrong but I couldn't figure out what specifically I was doing; if I have been an idiot, and these commits are unnecessary, please let me know because I'll be happy not to have needed them :-)
The commits can be applied individually. I wrote them in a hurry; hopefully they're reasonable?
There's one, de1cb25 (the "workaround" one) that should probably not be applied, but that I include for completeness because otherwise I do not seem to be able to get the build to go through.
Cheers, Tony
I wonder in the first place what the code cleanup was/or is in OpenSmalltalk that has happened over the last few weeks. Also see the report in https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/685 .
Hi Tony,
apologies for not having attended to these sooner. I'll try and get to them this week. I'm hopefully nearing the end of a Slang transpiler rewrite that is consuming all my cycles and head space ATM.
Cheers.
On Mon, Jul 8, 2024 at 1:12 AM Tony Garnock-Jones @.***> wrote:
Hello Eliot et al.,
I produced these commits to get Cog building on Debian sid/trixie from current git Cog branch. The number of faults suggested to me that I was holding it wrong but I couldn't figure out what specifically I was doing; if I have been an idiot, and these commits are unnecessary, please let me know because I'll be happy not to have needed them :-)
The commits can be applied individually. I wrote them in a hurry; hopefully they're reasonable?
There's one, de1cb25 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/de1cb25f24bfa10f22819f9f287c96e37557746d (the "workaround" one) that should probably not be applied, but that I include for completeness because otherwise I do not seem to be able to get the build to go through.
Cheers, Tony
You can view, comment on, or merge this pull request online at:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/688 Commit Summary
- f0d1f8e https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/688/commits/f0d1f8eca57913a9b5482ad1b2f18b712dec4411 Repair compilation of platforms/unix/plugins/DropPlugin/sqUnixDragDrop.c on Linux x86_64
- 970d324 https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/688/commits/970d324cd3a043f21795fa8f0e022fb1ae143002 Repair compilation of platforms/unix/vm-display-X11/sqUnixX11.c on Linux x86_64
- b32985e https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/688/commits/b32985e320d78ff9c72d56f4f7ed4ac691ee119c Repair compilation of vm-sound-* plugins on Linux x86_64
- de1cb25 https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/688/commits/de1cb25f24bfa10f22819f9f287c96e37557746d Grody workaround for missing function prototypes on the slang side
- ebf8203 https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/688/commits/ebf82033accda788d3ed0815fc13f1ea69e88318 Repair (?) signal-handler function signatures on Linux x86_64
File Changes
(9 files https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/688/files)
- M platforms/unix/plugins/DropPlugin/sqUnixDragDrop.c https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/688/files#diff-6897256c97145e1037506915ed980d7af1e015ee266c11429a2c04d4444dd7da (10)
- M platforms/unix/vm-display-X11/sqUnixX11.c https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/688/files#diff-bde6d852f3eaff3d4caa065c6bae7b9c2258516f4fb122756b60e9ac1a96f521 (1)
- M platforms/unix/vm-sound-ALSA/sqUnixSoundALSA.c https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/688/files#diff-a7b1f58c2090bcab992fa2d9d2578eb04f8c298290913b9edd487fa172867f9a (27)
- M platforms/unix/vm-sound-OSS/sqUnixSoundOSS.c https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/688/files#diff-56df7284a9f0a8e873ee5e9454138fb000b58806c4f0398c538d3325b8e53792 (25)
- M platforms/unix/vm-sound-null/sqUnixSoundNull.c https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/688/files#diff-625aa46670bfebb7a0beba8d7226e4e4a04886e06f9250c0208c7670be170e0b (8)
- M platforms/unix/vm-sound-pulse/sqUnixSoundPulseAudio.c https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/688/files#diff-456bfe6e5700f3db153e28ca1d028e993fa27f826d39736f14c8db4ff42a5090 (18)
- M platforms/unix/vm-sound-sndio/sqUnixSndioSound.c https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/688/files#diff-ea088c71fc980df4264ce6ce15ebe8fd7da894cc8c5789554e740fef8a78d8f2 (17)
- M platforms/unix/vm/sqPlatformSpecific.h https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/688/files#diff-1e2205111450e3c2454d06536419cb613576816730621bbf7fc881d9a2d08cd9 (6)
- M platforms/unix/vm/sqUnixMain.c https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/688/files#diff-b54a4e3a13ef8ebb1c82f3bce4d6930c230813fe76f3e998851746f332be0a62 (6)
Patch Links:
- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/688.patch
- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/688.diff
— Reply to this email directly, view it on GitHub https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/688, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADY5VUEI7HSX7PVGOTWTXCDZLJCXVAVCNFSM6AAAAABKQJSD3GVHI2DSMVQWIX3LMV43ASLTON2WKOZSGM4TIOJVGQZTONY . You are receiving this because you are subscribed to this thread.Message ID: @.***>
-- ,,,^..^,,, best, Eliot
On 8/20/24 20:56, Eliot Miranda wrote:
apologies for not having attended to these sooner. I'll try and get to them this week. I'm hopefully nearing the end of a Slang transpiler rewrite that is consuming all my cycles and head space ATM.
No problem, I'm immensely grateful for your work. Exciting to hear about the rewrite. Best of luck!
As the Cog branch builds and runs OK for me on linux64x64 now without this PR's changes, I think it's not required anymore. Hooray!