opensmalltalk-vm
opensmalltalk-vm copied to clipboard
OpenSmalltalk
Unable to rebind keyboard device in vm-display-fbdev (FrameBuffer) #575
Fix for bug:
Unable to rebind keyboard device in vm-display-fbdev (FrameBuffer) #575
Tested on arm32 Raspberry Pi 3 with Raspberry Pi OS (no X11) and on arm64 Le Potato (AML-S905S-XX) with Armbian OS.
Nota Bene: The include file ordering fix for arm64 does not seem to have been applied yet to the 32 bit platform.
Notes: [A] Given the superannuated nature of the code, it would be good to eliminate the ps2 mouse support and invert the logic so that the -DUSEEVDEV guard was inverted so as to make this code path the default code. Then this flag would no longer be required by the normal build. IMHO, this would be less confusing.
[B] The display_printUsage() help text options really need to be more thoroughly tested, e.g. by people using non-us keyboards.
On Tue, Jul 27, 2021 at 12:32 PM Ken Dickey @.***> wrote:
Notes: [A] Given the superannuated nature of the code, it would be good to eliminate the ps2 mouse support and invert the logic so that the -DUSEEVDEV guard was inverted so as to make this code path the default code. Then this flag would no longer be required by the normal build. IMHO, this would be less confusing.
If it works for you, go for it. You're the one driving fb-dev support these days. Make it the way you want it.
[B] The display_printUsage() help text options really need to be more thoroughly tested, e.g. by people using non-us keyboards.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/576#issuecomment-887778145, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADY5VUELDOJTHIPCDSCWNSTTZ4CUHANCNFSM5A6442CQ .
-- ,,,^..^,,, best, Eliot
Elided USEEVDEV flag & fixes a few nits. Tested mvm's & working on: Aarch64/arm64 [LePotato/Armbian] squeak.cog.spur/build squeak.cog.spur/build.debug squeak.stack.spur/build Arm32 [RPi3/Raspberry Pi OS] squeak.cog.spur/build squeak.cog.spur/build.debug
Looks ready to integrate..