open-simulation-interface icon indicating copy to clipboard operation
open-simulation-interface copied to clipboard

832 consolidate hosted osi documentation sources

Open philipwindecker opened this issue 1 year ago • 3 comments

Reference to a related issue in the repository

#832

Add a description

Remove legacy links.

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

If you can’t check all of them, please explain why. If all boxes are checked or commented and you have achieved at least one positive review, you can assign the label ReadyForCCBReview!

philipwindecker avatar Oct 22 '24 12:10 philipwindecker

I just had a second look, I think we also should change the proto file: https://github.com/OpenSimulationInterface/open-simulation-interface/blob/b00ad2b51ad47d4338429843b6c41217dd15461c/osi_version.proto.in#L31

As expected, this shows also up in the documentation. image

I would simply write something like:

The meaning of different InterfaceVersions is defined in the versioning chapter of the official OSI documentation.

Or if somebody really wants a reference, than point to a page that actually explains this like https://opensimulationinterface.github.io/osi-antora-generator/asamosi/V3.7.0/specification/general_docs/versioning.html (this is a fixed 3.7. link..)

TimmRuppert avatar Oct 22 '24 14:10 TimmRuppert

I just had a second look, I think we also should change the proto file:

https://github.com/OpenSimulationInterface/open-simulation-interface/blob/b00ad2b51ad47d4338429843b6c41217dd15461c/osi_version.proto.in#L31

As expected, this shows also up in the documentation. image

I would simply write something like:

The meaning of different InterfaceVersions is defined in the versioning chapter of the official OSI documentation.

Or if somebody really wants a reference, than point to a page that actually explains this like https://opensimulationinterface.github.io/osi-antora-generator/asamosi/V3.7.0/specification/general_docs/versioning.html (this is a fixed 3.7. link..)

This is true and I noticed it as well. However, it technically would still be correct, since the retrieval date is given (meaning it does not need to stay available).

But I agree that it would be better to point to the documentation (with an updated date) and not the README (whose link is not working any longer). A fixed version, however, will only work if the version is not latest (in the current setup, at least).

For now, I will go without the link.

philipwindecker avatar Oct 22 '24 15:10 philipwindecker

@pmai and @engelben how would we proceed without a CCB in place? Shall I merge through the power of Grayskull

th

jdsika avatar Oct 23 '24 06:10 jdsika

Let’s keep the spirit of Eternia alive! 🚀

@jdsika I am fine if you go ahead with the merge, we have enough members of the prior CCB that have approved this topic and the changes are editorial.

engelben avatar Nov 13 '24 15:11 engelben