open-simulation-interface icon indicating copy to clipboard operation
open-simulation-interface copied to clipboard

Draft for discussion: Added element tricycle

Open FlorianMueller87 opened this issue 3 years ago • 1 comments

Reference to a related issue in the repository

Issue: #639

Add a description

ASAM OSI and ISO 23150 or AUTOSAR ADI have a common history. Unfortunately, the inner structure, the naming and the definitions of the standards are differentiated from each other. This makes the work of developers unnecessary complicated for mostly no technical reasons. All sides should strive to reduce inequality.

ASAM OSI need the entry TYPE_TRICYCLE for osi_objects – MovingObject - VehicleClassification – Type to be compatible with AUTOSAR ADI PotentiallyMovingObjectClassificationType.

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

  • [x] My suggestion follows the style and contributors guidelines.
  • [x] I have taken care about the documentation.
  • [x] I have done the DCO signoff.
  • [x] My changes generate no errors when passing CI tests.
  • [ ] I have successfully implemented and tested my fix/feature locally.
  • [ ] Appropriate reviewer(s) are assigned.

Additional context

ISO23150:2021 A.76 Enumeration: Potentially moving object classification type

@ThomasNaderBMW @jdsika @schmidtlorenz

FlorianMueller87 avatar Aug 10 '22 06:08 FlorianMueller87

Questions:

  • The first thing coming to mind is "what is the definition of a tricycle"? Is it the one from WW2 where we have a motorbike with a side car or is it rather a chrildrens toy?
  • If AUTOSAR sees the need for this type could you also provide their proper defintion, please?
  • The TRUCKS e.g. already have some pictures from #585 but most of the defintions are also lacking precision in description which needs further refinement (does AUTOSAR have some nice definitions there as well?)

TODO:

  • Define the SVGs for the small car and other types as well - this would be breaking change...
  • Comment from @pmai : Either have only one car and not separate by length or other attributes OR comment from @jdsika you define car types by different shapes like VAN, SEDAN, COMBI, etc

IMPORTANT: Find the motivation for defining the different types. Sensor modelling, driving strategy?

Apart from these remarks I do not see a reason to not include this suggestion.

jdsika avatar Oct 17 '22 07:10 jdsika

Harmonization discussion: "What is a tricycle?"

  • With or without motor?
  • Bike with three wheels
  • TukTuk
  • Motorbike with side car
  • Trike
  • Vehicles with closed wheels (front/back)

Please clarify it in more detail.

thempen avatar Nov 23 '22 10:11 thempen