open-simulation-interface icon indicating copy to clipboard operation
open-simulation-interface copied to clipboard

Draft for discussion: Feature/add elements to stationary object classification type

Open FlorianMueller87 opened this issue 2 years ago • 1 comments

Reference to a related issue in the repository

#641

Add a description

ASAM OSI and ISO 23150 or AUTOSAR ADI have a common history. Unfortunately, the inner structure, the naming and the definitions of the standards are differentiated from each other. This makes the work of developers unnecessary complicated for mostly no technical reasons. All sides should strive to reduce inequality.

ASAM OSI need the entries for osi_objects – StationaryObject – Classification - Type to be compatible with AUTOSAR ADI GeneralLandmarkClassificationType.

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

  • [x] My suggestion follows the style and contributors guidelines.
  • [x] I have taken care about the documentation.
  • [x] I have done the DCO signoff.
  • [x] My changes generate no errors when passing CI tests.
  • [ ] I have successfully implemented and tested my fix/feature locally.
  • [ ] Appropriate reviewer(s) are assigned.

Additional context

ISO23150:2021 A.2.105 General landmark classification type

@ThomasNaderBMW @jdsika @schmidtlorenz

FlorianMueller87 avatar Aug 09 '22 13:08 FlorianMueller87

Comments:

  • Tunnel: This is part of Lane Boundary:Type:Structure. Why would we have tunnels without lanes going through them? Is it meant as an overhead structure? Please provide the documentation on how ADI did define tunnels in general and how differentiate between bridge, overhead structrue or rectengular structure?
  • Barrel: This could already be a TYPE_DELINEATOR or TYPE_BARRIER - why is further definition needed? What is exacly the definition of the BARREL?
  • Guide Post: This is a TYPE_REFLECTIVE_STRUCTURE?
  • It is a unique type

TODO:

  • SHARPEN definitions and ADD images
  • Potentially we have overdefined types here

jdsika avatar Oct 17 '22 08:10 jdsika