open-simulation-interface icon indicating copy to clipboard operation
open-simulation-interface copied to clipboard

Draft for discussion: Feature/add elements to measurement state

Open FlorianMueller87 opened this issue 3 years ago • 4 comments

Reference to a related issue in the repository

#648

Add a description

ASAM OSI and ISO 23150 or AUTOSAR ADI have a common history. Unfortunately, the inner structure, the naming and the definitions of the standards are differentiated from each other. This makes the work of developers unnecessary complicated for mostly no technical reasons. All sides should strive to reduce inequality.

ASAM OSI need the entries for osi_detectedobject – DetectedItemHeader – MeasurementState to be compatible with AUTOSAR ADI MeasurementStatus.

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

  • [x] My suggestion follows the style and contributors guidelines.
  • [x] I have taken care about the documentation.
  • [x] I have done the DCO signoff.
  • [x] My changes generate no errors when passing CI tests.
  • [ ] I have successfully implemented and tested my fix/feature locally.
  • [ ] Appropriate reviewer(s) are assigned.

Additional context

ISO23150:2021 A.2.9 Measurement status – object level @ThomasNaderBMW @jdsika @schmidtlorenz

FlorianMueller87 avatar Aug 09 '22 13:08 FlorianMueller87

Comment:

  • @carsten-kuebler we need some better explanations in the ISO what is the reason and difference for PREDICTED_OCCLUDED and PREDICTED?
  • HOW is something INVALID?

jdsika avatar Oct 17 '22 08:10 jdsika

@jdsika

  • PREDICTED: sorry typo, thanks.
  • ISO definition: PREDICTED: The object was predicted without any new information with respect to the previous update cycle.
  • ISO definition: PREDICTED_OCCLUDED: Tracked object is temporarily occluded by another entity.
  • PARTLY_MEASURED in ISO23150: It is wrong in ADI. We will chang this in ADI and I will correct this here.
  • INVALID: The measurement result is invalid. : My thought on this is e.g. two sensors getting different results. I will discuss this on ADI board.

FlorianMueller87 avatar Nov 01 '22 08:11 FlorianMueller87

I personally think that PARTIALLY_MEASURED is in terms of the English language correct. If that is a non-binding example from the annex again you are also not "wrong" in ADI as it is just an example :)) But the explanation/definition of the word is actually the important thing and if a Tier1 needs/uses a signal with that definition.

jdsika avatar Nov 02 '22 12:11 jdsika

Comment from WG Harmonization: Please provide further information on when to use the suggested measurement states and what additional information can be gathered in addition to the existing description. It is unclear how to use it together with the existence_probability and age fields.

thempen avatar Dec 07 '22 11:12 thempen