open-simulation-interface icon indicating copy to clipboard operation
open-simulation-interface copied to clipboard

Draft for discussion: Added new elements to DataQualifier

Open FlorianMueller87 opened this issue 3 years ago • 3 comments

Added new elements to DataQualifier (REDUCE_INVIEW_AND_PERFORMANCE, TEST_MODE, INVALID, REDUCED_PERFORMANCE)

#### Reference to a related issue in the repository

Issue: #646

Add a description

ASAM OSI and ISO 23150 or AUTOSAR ADI have a common history. Unfortunately, the inner structure, the naming and the definitions of the standards are differentiated from each other. This makes the work of developers unnecessary complicated for mostly no technical reasons. All sides should strive to reduce inequality.

ASAM OSI need the entries for osi_sensordata - DetectedEntityHeader – DataQualifier to be compatible with AUTOSAR ADI DataQualifier.

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

  • [x] My suggestion follows the style and contributors guidelines.
  • [x] I have taken care about the documentation.
  • [x] I have done the DCO signoff.
  • [x] My changes generate no errors when passing CI tests.
  • [ ] I have successfully implemented and tested my fix/feature locally.
  • [ ] Appropriate reviewer(s) are assigned.

Additional context

ISO23150:2021 A.1.9 Data qualifier @ThomasNaderBMW @jdsika @schmidtlorenz

FlorianMueller87 avatar Aug 09 '22 12:08 FlorianMueller87

@FlorianMueller87 please add the ADI table here to discuss the needed changes as the proposed changes here are not the ones from the released ISO

jdsika avatar Oct 17 '22 08:10 jdsika

kNormal 0x00 Information can be used without restriction. kNotAvailable 0x01 Information from the senor is not available. kReduceInCoverage 0x02 Reported data are from the sensor in a restricted view. kReduceInPerformance 0x03 Reported data are from the sensor in a restricted performance. kReduceInViewAndPerformance 0x04 Reported data are from the sensor in a restricted view and performance. kTestMode 0x05 Reported data are from the sensor in a test mode. kInvalid 0x06 Mesaurement cycle was invalid and no valid objects will be reported. kUnknown 0x07 Data quality is unknown.

FlorianMueller87 avatar Nov 01 '22 11:11 FlorianMueller87

Comment from WG Harmonization: We need further information about the provided list. Please describe, in which situation the various cases will be used. Please describe the "view" and "coverage", shouldn't there be a uniform wording?

thempen avatar Dec 07 '22 11:12 thempen