open-simulation-interface icon indicating copy to clipboard operation
open-simulation-interface copied to clipboard

ISO23150 compliance: Adding new element to [ColorDescription]

Open FlorianMueller87 opened this issue 3 years ago • 5 comments

Describe the feature

ASAM OSI and ISO 23150 or AUTOSAR ADI have a common history. Unfortunately, the inner structure, the naming and the definitions of the standards are differentiated from each other. This makes the work of developers unnecessary complicated for mostly no technical reasons. All sides should strive to reduce inequality. ASAM OSI need the entries for osi_common - ColorDescription to be compatible with AUTOSAR ADI ColourClassificationType.

Describe the solution you would like

Add in osi_common - ColorDescription the following element:

optional ColorList list = 7;

With:

message ColorList
{
    optional List = 1;
    enum List
    {
   	    // Color is unknown (must not be used in ground truth).
            //
            COLOR_UNKNOWN = 0;

            // Other (unspecified but known) color.
            //
            COLOR_OTHER = 1;

            // Yellow.
            //
            COLOR_YELLOW = 2;

            // Green.
            //
            COLOR_GREEN = 3;

            // Blue.
            //
            COLOR_BLUE = 4;

            // Violet.
            //
            COLOR_VIOLET = 5;

            // Red.
            //
           COLOR_RED = 6;

            // Orange.
            //
            COLOR_ORANGE = 7;

            // Black.
            //
            COLOR_BLACK = 8;

            // GREY.
            //
            COLOR_GREY = 9;

            // White.
            //
            COLOR_WHITE = 10;
        }
 }

Describe alternatives you have considered

No alternative was considered.

Describe the backwards compatibility

The adding of the elements will not lead to backward compatibility issues.

Additional context

ISO23150:2021 A.1.15 Colour model type @ThomasNaderBMW @jdsika @schmidtlorenz

FlorianMueller87 avatar Jul 05 '22 08:07 FlorianMueller87

For what are those colors used? The color enums will be deprecated in OSI with v4.0.0 and replaced by this defintion - example:

◆ Color

enum osi3::CameraDetection::Color

Definition of shape dominant color.

Attention
DEPRECATED: This color enum will be removed in version 4.0.0. Use ColorDescription instead.

jdsika avatar Aug 02 '22 13:08 jdsika

It looks like it will not used anywhere. I will bring this up with ISO.

FlorianMueller87 avatar Aug 05 '22 13:08 FlorianMueller87

At the moment, ISO as well as ADI did not use ColorList. It was implemented for future issues. If you not see any usage for it, I can live with rejecting this issue for the moment.

FlorianMueller87 avatar Aug 09 '22 11:08 FlorianMueller87

Comment:

  • In future we will only use ENUM colors with semantic menaing like "a red traffic light" where the type of red is not relevant but only the information that a car etc. has to stop
  • The other enum color lists will be deprecated as mentioned and replaced by color descriptions

jdsika avatar Oct 17 '22 09:10 jdsika

Could you check the color model with ISO23150 please? @carsten-kuebler

jdsika avatar Oct 17 '22 12:10 jdsika