open-simulation-interface
open-simulation-interface copied to clipboard
OpenSimulationInterface
Clarifications on curbs and other boundaries with a height
modifications and clarifications for curbs and other lane boundaries having a 'height'
Signed-off-by: Habedank Clemens [email protected]
#### Reference to a related issue in the repository Add a reference to a related issue in the repository.
Add a description
This PR is a suggestion which was preceded by discussion in the Road Model WP. It is basically reasoned by certain unclarities in the current definition of curbs:
- Do the boundary points describing a curb lie "inside" the curb on the level of the lower side of the curb? Because a lane boundary has a width going to the left/right from its middle...
- In wich direction points the height? Currently there is no surface definition (see https://github.com/OpenSimulationInterface/open-simulation-interface/pull/436)
- Is it allowed to have a lane boundary of type curb referenced from the left and the right lane? Should this take the height of the curb into account (e.g. for sidewalk yes, for normal driving lane no)?
This definition tries to fix those unclarities and needs to be seen in combination with https://github.com/OpenSimulationInterface/open-simulation-interface/pull/600
Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:
- [ ] My suggestion follows the style and contributors guidelines.
- [ ] I have taken care about the documentation.
- [ ] I have done the DCO signoff.
- [ ] My changes generate no errors when passing CI tests.
- [ ] I have successfully implemented and tested my fix/feature locally.
- [ ] Appropriate reviewer(s) are assigned.
If you can’t check all of them, please explain why. If all boxes are checked or commented and you have achieved at least one positive review, you can assign the label ReadyForCCBReview!
With the latest change in https://github.com/OpenSimulationInterface/open-simulation-interface/pull/608/commits/6526e0a29d4e5656d80a49a41232a874208d226c this PR is seen more as a bugfix to the current definition, because modelling curbs with only one laneboundary of type curb and a height field makes the height of adjacent lanes ambiguous. This PR makes it clearer that a curb must be modelled with two laneboundary's while deprecation of TYPE_CURB can of course be done in v4.0 earliest.
The basic issue is now resolved by https://github.com/OpenSimulationInterface/open-simulation-interface/pull/634. This PR can be closed by future Road Model work if not seen helpful.
The basic issue is now resolved by https://github.com/OpenSimulationInterface/open-simulation-interface/pull/634. This PR can be closed by future Road Model work if not seen helpful.
The basic issue is now resolved by https://github.com/OpenSimulationInterface/open-simulation-interface/pull/634. This PR can be closed by future Road Model work if not seen helpful.