Duplicate Effect entry in clip Properties dropdown list

[leodf1]

Describe the bug: When clicking the Effect icon in the clip header, a duplicate entry is created in the clip's Property dropdown list

Steps to reproduce the behavior:

1. Apply an Effect to a clip
2. Click the Effect icon in the clip header
3. Select the clip
4. Open the dropdown menu of the Property panel
5. Two Effect entries are listed

Expected behavior: A clear and concise description of what you expected to happen.

System Details:

• OpenShot Version [e.g. 2.4.3]: {{ log_context.openshot_qt_version }}
• Operating System / Distro: [e.g. Windows 10, Linux Mint 17.1]

Log Files: If you are experiencing a crash, please collect and attach logs of the problem. Log files can be found in the .openshot_qt folder in your user home directory. Log files over 2 MB in size will need to be compressed, please attach a ZIP file instead of the raw logs.

Exception / Stacktrace: If you are experiencing a crash or strange output on the command line, please attach a small snippet of the exception here, but please keep it as small as possible (for readability).

Screenshots: (Optional) If applicable, add screenshots to help explain your problem. To include screenshots, copy/paste them here, drag the image(s) into this form, or click the link below this edit field to load images saved to your computer. All images are public, so please don't post screenshots containing personal information.

[leodf1]

Not sure if this is a bug or an undocumented feature.

Once an Effect has been applied to a clip, an Effect icon is added to the clip header.

As long as that Effect icon is never clicked, the Effect is listed with the clip in the Property dropdown list for the clip The moment the Effect icon is clicked, a second Effect entry is added to the dropdown Property list for the clip.

Follow these steps:

Add an Effect to a clip Select the clip Go to its Properties Click the dropdown list at the top of the Property panel The clip is listed together with the Effect

Now click the Effect icon on the clip Click the clip Open the dropdown list of the Property panel Now there are two entries for the Effect. One with an arrow.

[Colorjet3]

Hello @leodf1. I am able to replicate this in my Windows 11 Pro and Ubuntu 22.04 lts environments. However, after further testing I think this is by design. Give this a try:

1. Add an Effect to a clip. Actually, add the "Alpha Mask / Wipe Transition" effect.
2. Select the clip.
3. Go to its Properties.
4. Click the dropdown list at the top of the Property panel.
5. The clip is listed together with the Effect.

So far these are the steps you provided above (the first grouping). What you should notice here is that the Effect has the arrow to the left of it. Please confirm this.

Now continue with the 2nd set of instructions you provided:

1. Now click the Mask Effect icon on the clip.
2. Click the clip
3. Open the dropdown list of the Property panel.
4. Now there are two entries for the Mask Effect.

Here we can confirm that there are two entries for the Mask effect, one with an arrow to the left of it and another without an arrow.

Let's continue...

1. Drag the Bars effect onto this same clip.
2. Click on the Bars effect icon on the clip.
3. Click on the clip.
4. Open the dropdown list of the Property panel.
5. You should now see:

• The clip name
• the Mask effect with an arrow.
• the Bars effect with an arrow.
• the Bars effect without an arrow.

What OpenShot is telling you is that this clip has two effects applied (the arrows...) and that you are currently focused on the Bars effect.

Go ahead and add another effect (For example; Caption) and you can see how the drop down down grows.

Honestly, I don't see the benefit of listing the effect that you are focused on twice. You can just click on the effect icon on the clip or click on the drop down menu and select the effect (with the arrow next to it).

This very well could have been a function/feature that evolved over time and it didn't get the proper review, logic wise, and cleaned up or implemented properly.

I think we can flag this as an enhancement request to clean it up. It isn't doing any damage that I can see.

What are your thoughts?

[leodf1]

I agree.

I was not sure whether I was missing some practical use of the double entries since none of it is covered by the manual.

Good job, thanks