SolrTextTagger icon indicating copy to clipboard operation
SolrTextTagger copied to clipboard

SolrJ extension for SolrTextTagger

Open westei opened this issue 8 years ago • 4 comments

Hi all,

Not really an issue, but I wanted to let you know that I implemented SolrParams, SolrRequest and SolrResponse specific for the SolrTextTagger.

The module is available at https://github.com/redlink-gmbh/solrj-text-tagger/ I plan to make it available at Maven Central in the coming days.

Feedback welcome!

best Westei

westei avatar Jul 14 '16 10:07 westei

Very cool! After we switch to Java 8 (which I see this code requires as it uses .stream()), what do you think of providing this code with the text tagger? It would probably result in another module but I think that's better than separate projects altogether.

dsmiley avatar Jul 17 '16 04:07 dsmiley

I should definitely be an own module (as it only depends on SolrJ and does not have a direct dependency to the SolrTextTagger module. I have no problem of managing it at the above location, but maybe SolrTextTagger user will more likely find it when it is made available under the same groupId as the solr-text-tagger.

Regarding Java 8: I was in the impression that Solr 6 requires Java 8. In SolrJ they renamed some of the main classes with Solr 6. So to support older Java versions one would need to provide two separate releases (one for SolrJ 6 and SolrJ 5)

westei avatar Jul 18 '16 04:07 westei

I just released 2.3 and bumped the tagger to Solr 6 and Java 8.

Yes, Solr 6 requires Java 8. Feel free to send a pull request for this contribution. Perhaps the SolrJ module can be a child of the existing one, without having to move the current code to a new subdirectory -- that'd be nice.

dsmiley avatar Jul 20 '16 05:07 dsmiley

Now that Solr 7.4.0 includes the tagger, perhaps you might want to propose your addition directly to Apache Solr / SolrJ.

dsmiley avatar Jun 29 '18 20:06 dsmiley