mosaic-contracts icon indicating copy to clipboard operation
mosaic-contracts copied to clipboard

Integration tests should use Gateway/CoGateway interaction helpers

Open abhayks1 opened this issue 5 years ago • 2 comments

Context

Both MPP generator tool and Integration tests does stake & mint and redeem & unstake flow. In MPP generator tool Gateway and CoGateway interaction methods has been refactored to helpers: *mosaic-contracts/proof_generation/helper/ **

For usability perspective and to avoid repeated code it makes sense for integration tests to use these helpers 📚 . Refer discussion: https://github.com/OpenST/mosaic-contracts/pull/717#issuecomment-487012473

Proposal

  • Decide on ideal location for these helpers as currently they sit in proof_generation folder.

  • Make changes in the helpers so that they are usable both for the tool 🔧 and integration tests.

  • Update the caller code accordingly.

The ticket should be done after below PR is merged: https://github.com/OpenST/mosaic-contracts/pull/717

abhayks1 avatar Apr 26 '19 12:04 abhayks1

https://github.com/OpenST/mosaic-contracts/pull/717#issuecomment-491196489

Will create a ticket to integrate proof generator with truffle exec 👍

will wait for this ticket before moving this ticket forward.

benjaminbollen avatar May 10 '19 11:05 benjaminbollen

Ticket created: https://github.com/OpenST/mosaic-contracts/issues/731

abhayks1 avatar May 10 '19 12:05 abhayks1