openspp-modules icon indicating copy to clipboard operation
openspp-modules copied to clipboard

[IMP] spp_openid_vci: close windown when clicking confirm button

Open reichie020212 opened this issue 8 months ago • 2 comments

Why is this change needed?

Issue Card modal is not closing after clicking confirm button

How was the change implemented?

added close="1" parameter to the button.

New unit tests

None

Unit tests executed by the author

None

How to test manually

  • Install spp_openid_vci_individual
  • Go to Registry -> Individual
  • enter 1 record.
  • click the Issue Card smart button
  • click confirm button
  • after the generation of the ID card, the modal should be automatically closed.

Related links

reichie020212 avatar Apr 30 '25 08:04 reichie020212

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.67%. Comparing base (bb28b61) to head (d9435af). Report is 38 commits behind head on 17.0.

Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #796      +/-   ##
==========================================
- Coverage   75.69%   75.67%   -0.03%     
==========================================
  Files         764      764              
  Lines       20218    20218              
  Branches     2501     2501              
==========================================
- Hits        15304    15299       -5     
- Misses       4380     4382       +2     
- Partials      534      537       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Apr 30 '25 08:04 codecov[bot]

Findings: blocked

unable to complete testing as i am unable to succeed issuing a card to an individual in registry image

tested on runboat instance: http://openspp-openspp-modules-17-0-e6bb1a1716f5.runboatk8.newlogic-demo.com/web/login

anthonymarkQA avatar Jul 22 '25 00:07 anthonymarkQA

Findings: QA passed

modal automatically closes when confirmed - pass automatically downloads the PDF file of the ID - pass

image image

anthonymarkQA avatar Jul 22 '25 07:07 anthonymarkQA