openspp-modules icon indicating copy to clipboard operation
openspp-modules copied to clipboard

Modify the spp_change_request module to support SP-MIS and Farmer Registry CR type modules

Open gonzalesedwin1123 opened this issue 8 months ago • 2 comments

Why is this change needed?

A new spp_change_request_base module is created in PR: #777 to support any change request implementations. This PR will modify the existing spp_change_request to support only the SP-MIS and Farmer Registry change request implementations.

How was the change implemented?

The spp_change_request module was modified and will depend on the new parent module spp_change_request_base. SP-MIS and Farmer Registry specific change request requirements will be maintained in this module.

New unit tests

Unit tests executed by the author

How to test manually

Related links

Enhancement to Change Request module

gonzalesedwin1123 avatar Apr 15 '25 11:04 gonzalesedwin1123

Codecov Report

Attention: Patch coverage is 70.66667% with 66 lines in your changes missing coverage. Please review.

Project coverage is 76.47%. Comparing base (7eb47f9) to head (2d4a8c3). Report is 49 commits behind head on 17.0.

Files with missing lines Patch % Lines
spp_change_request/models/change_request.py 43.47% 24 Missing and 2 partials :warning:
spp_api/controllers/pinguin.py 0.00% 15 Missing :warning:
spp_change_request/models/mixins/source_mixin.py 25.00% 9 Missing :warning:
spp_starter/wizards/spp_starter.py 77.77% 2 Missing and 6 partials :warning:
...armer_registry_demo/models/generate_farmer_data.py 20.00% 4 Missing :warning:
spp_starter/tests/test_spp_starter.py 85.71% 3 Missing :warning:
spp_mis_demo/models/generate_group.py 85.71% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #791      +/-   ##
==========================================
+ Coverage   75.68%   76.47%   +0.78%     
==========================================
  Files         764      757       -7     
  Lines       20218    19984     -234     
  Branches     2501     2444      -57     
==========================================
- Hits        15303    15283      -20     
+ Misses       4381     4170     -211     
+ Partials      534      531       -3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Apr 15 '25 11:04 codecov[bot]

Quality Gate Failed Quality Gate failed

Failed conditions
37.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

sonarqubecloud[bot] avatar Jul 04 '25 04:07 sonarqubecloud[bot]