openspp-modules icon indicating copy to clipboard operation
openspp-modules copied to clipboard

[UPG] spp_sms: upgrade spp_sms to 17.0

Open reichie020212 opened this issue 9 months ago • 5 comments

Why is this change needed?

spp_sms module is still in another repo and is still in 15.0

How was the change implemented?

Moved the spp_sms module to this repo and migrated it to 17.0

New unit tests

Unit tests executed by the author

How to test manually

Related links

reichie020212 avatar Mar 25 '25 10:03 reichie020212

Codecov Report

:x: Patch coverage is 90.02268% with 44 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 76.00%. Comparing base (d840c60) to head (6ec4f45). :warning: Report is 54 commits behind head on 17.0.

Files with missing lines Patch % Lines
spp_sms/models/iap_account.py 40.42% 28 Missing :warning:
spp_sms/models/mailing_mailing.py 91.56% 1 Missing and 6 partials :warning:
spp_sms/tools/sms_api.py 73.07% 7 Missing :warning:
spp_sms/tests/test_mailing_mailing.py 98.56% 0 Missing and 2 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #785      +/-   ##
==========================================
+ Coverage   75.67%   76.00%   +0.32%     
==========================================
  Files         764      778      +14     
  Lines       20218    20659     +441     
  Branches     2501     2541      +40     
==========================================
+ Hits        15300    15701     +401     
- Misses       4382     4416      +34     
- Partials      536      542       +6     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Mar 25 '25 10:03 codecov[bot]

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

github-actions[bot] avatar Mar 31 '25 07:03 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA

megaxayda avatar Mar 31 '25 07:03 megaxayda

@gonzalesedwin1123 if you could also review this, I'd be grateful. Thanks.

kneckinator avatar Apr 02 '25 06:04 kneckinator

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Aug 24 '25 12:08 github-actions[bot]