openspp-modules icon indicating copy to clipboard operation
openspp-modules copied to clipboard

Change Request Add Group to Group (Generic)

Open jannahadlaon opened this issue 10 months ago • 1 comments

Describe the bug

  1. CR for adding a group to a group adds the Group itself, not the members inside the group. See screenshots below: https://drive.google.com/file/d/1L2Xv9jPkzpy8ZzimXX-kx1dSp0T2zvdG/view?usp=sharing https://drive.google.com/file/d/1KcajtD_3_TI5aWO0_m1p0zJvxRu2Uu1T/view?usp=sharing

  2. Requesting Group should be excluded in the list of groups you can add to a group. Ex: Requesting group (Name: Test G4) should not see their group name as an option under groups they can add. https://drive.google.com/file/d/13UysOrP0Y_v6nXNLwrE9DzzypLmkNJnj/view?usp=drive_link https://drive.google.com/file/d/1n_kB2UVxx5BlznUmYV-YxVVmtnspXyJV/view?usp=drive_link https://drive.google.com/file/d/1nBF2sqh3MXngV8Hgp1aAGuLZeuawgqtv/view?usp=sharing

To Reproduce

Bug 1

  1. In Apps tab, install Farmer demo using Starter
  2. Install spp_change_request_add_group_to_group
  3. Go to Registry tab
  4. Create 2 Groups (Test G1 and Test G2)
  5. Go to Change request tab
  6. Click on "New"
  7. Select Request type: Add Group to a Group
  8. Select Test G1 as the Registrant and add Test G2 to Test G1 group
  9. Request for validation
  10. Log in as local validator and validate in Local
  11. Log in as HQ validator and validate in HQ
  12. Log in back as admin and go to Registry
  13. Check Group Test G1
  14. Click on members tab - _see issue here_est G2 is listed as member of Test G1 and none of the members under Test G2 is listedttps://drive.google.com/file/d/1L2Xv9jPkzpy8ZzimXX-kx1dSp0T2zvdG/view?usp=sharing2. Click on the green button beside the name of Test G2
  15. In the popup, click the green button again button beside the name of Test G2 - see issue here https://drive.google.com/file/d/1KcajtD_3_TI5aWO0_m1p0zJvxRu2Uu1T/view?usp=sharing

Bug 2

  1. In Apps tab, install Farmer demo using Starter
  2. Install spp_change_request_add_group_to_group
  3. Go to Registry tab
  4. Create 1 Groups (Test G4)
  5. Go to Change request tab
  6. Click on "New"
  7. Select Request type: Add Group to a Group
  8. Select Test G4 as the Registrant - _see issue here_After selecting Test G4 as the registrant, you can still select it as one of the groups you can add.https://drive.google.com/file/d/13UysOrP0Y_v6nXNLwrE9DzzypLmkNJnj/view?usp=drive_linkhttps://drive.google.com/file/d/1n_kB2UVxx5BlznUmYV-YxVVmtnspXyJV/view?usp=drive_link https://drive.google.com/file/d/1nBF2sqh3MXngV8Hgp1aAGuLZeuawgqtv/view?usp=sharing

Expected behavior

  1. When adding a group to a group, the members of the group should be added as well
  2. Requesting Group should be excluded in the list of groups you can add to a group.

Screenshots https://drive.google.com/file/d/1L2Xv9jPkzpy8ZzimXX-kx1dSp0T2zvdG/view?usp=sharing https://drive.google.com/file/d/1KcajtD_3_TI5aWO0_m1p0zJvxRu2Uu1T/view?usp=sharing https://drive.google.com/file/d/13UysOrP0Y_v6nXNLwrE9DzzypLmkNJnj/view?usp=drive_link https://drive.google.com/file/d/1n_kB2UVxx5BlznUmYV-YxVVmtnspXyJV/view?usp=drive_link https://drive.google.com/file/d/1nBF2sqh3MXngV8Hgp1aAGuLZeuawgqtv/view?usp=sharing

Additional context Related to: https://github.com/OpenSPP/openspp-modules/issues/744

🔔 Note: This ticket should address common considerations without including country-specific content. Please ensure all references are generic and applicable across various contexts.

jannahadlaon avatar Feb 19 '25 09:02 jannahadlaon

From expected behavior:

  1. It should not include the members of the group being added. Only the group itself.
  2. Yeah, I saw this too let me fix it.

@celinenilla can you confirm #1?

emjay0921 avatar Feb 21 '25 00:02 emjay0921