improved showing of error in vci module
Why is this change needed?
Upon printing the vci issuer, the invoice is printed instead of vci issuer and this is happening on a random occasion
How was the change implemented?
Now, I added an argument config=False so that it will always go to the vci issuer
How to test manually
- Install module
spp_openid_vci_individual - Go to settings and click
Activate the developer mode - Go to Settings -> User & Companies -> Users.
- Enter the record Administrator.
- Go to Access Rights tab and check the
Crypto AdminRole - Refresh the page. You should now be able to see the
Encryption ProvidersMenu on top of the page. Click that menu. - Enter the
Default encryption providerrecord. - In
Typefield, select theJWCryptothen Click the buttonCreate Jwcrpyto Keythen Save. - Go to VCI Issuer menu and create a record.
- Fillup only the following: Name, Scope, Issuer Type, Supported Format, Encryption Provider, and Auth Subject ID Type
- Upon saving, other fields will be automatically fill-up.
- Go to Registry -> Individuals and create or update a record.
- Make sure the the Individual have an ID type with the same ID Type selected in
Auth Subject ID Type - Click the
Issue Cardbutton in the top-middle of the page. - Select the Issuer that was created earlier then click Confirm.
- There should be a downloaded pdf file for vci issuer.
Related links
https://github.com/OpenSPP/openspp-modules/issues/372
Codecov Report
Attention: Patch coverage is 90.90909% with 6 lines in your changes missing coverage. Please review.
Project coverage is 72.75%. Comparing base (
26fe80a) to head (0e917a8). Report is 3 commits behind head on 17.0.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| spp_openid_vci/tools/tools.py | 82.85% | 6 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## 17.0 #619 +/- ##
========================================
Coverage 72.74% 72.75%
========================================
Files 618 667 +49
Lines 16455 17241 +786
Branches 2116 2189 +73
========================================
+ Hits 11971 12544 +573
- Misses 4097 4297 +200
- Partials 387 400 +13
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
- Flaky Tests Detection - Detect and resolve failed and flaky tests
- JS Bundle Analysis - Avoid shipping oversized bundles
Quality Gate passed
Issues
1 New issue
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code