openspp-modules icon indicating copy to clipboard operation
openspp-modules copied to clipboard

Target type in create program modal is not working

Open anthonymarkQA opened this issue 1 year ago • 1 comments

Describe the bug Switching between Group or Individual as target type when creating a program does not work in farmer registry To Reproduce

  1. Go to farmer registry QA and login as admin
  2. Click on Programs
  3. Click on Create a program
  4. Notice in the create program modal, switching between target types does not affect record count that is found.

Expected behavior Switching between group and individual should target the record type accordingly and should not display records unrelated to the selected target type Screenshots

Image

Image

anthonymarkQA avatar Aug 14 '24 02:08 anthonymarkQA

Upon checking, the error is due to spp_programs module is not installed since the fix for this is only added in spp_programs.

reichie020212 avatar Aug 19 '24 03:08 reichie020212

Findings: QA Passed

installing programs for farmer registry should also install spp_programs as this makes the program module target type work as expected.

Image

anthonymarkQA avatar Sep 03 '24 06:09 anthonymarkQA

@reichie020212 I guess there are code changes related to this issue. Could you see if you can link the PR to this issue? Thanks.

kneckinator avatar Sep 03 '24 09:09 kneckinator

Hi @kneckinator the code related to this was first done in odoo 15 last April 23, 2023 and I am not able to find the PR for that But i can attach the PR that migrates the code from Odoo 15 to Odoo 17.

reichie020212 avatar Sep 03 '24 12:09 reichie020212

@kneckinator here is the PR https://github.com/OpenSPP/openspp-modules/pull/335, i'm not sure why i can't attach it in this ticket so i'll just put here in the comment section.

reichie020212 avatar Sep 03 '24 12:09 reichie020212

Upon checking, the error is due to spp_programs module is not installed since the fix for this is only added in spp_programs.

Seeing this comment, it is likely that the correct status of this issue should be "Closed" with status "Invalid" (which is a status we don't have, so right now I'll use "Won't do").

FYI @dasunhegoda @anthonymarkQA

kneckinator avatar Sep 04 '24 11:09 kneckinator