oscap-anaconda-addon icon indicating copy to clipboard operation
oscap-anaconda-addon copied to clipboard

Published 20 hours ago • verified publisher icon OpenSCAP

Handle archives and preferred content better

Open matejak opened this issue 2 years ago • 7 comments

The addon lost the ability to pick files from supplied archives based on kickstart specifications. This PR allows this, which allows the addon to

  • handle archives with e.g. multiple datastream files, and to
  • throw error when an expected file in the archive is missing.

This PR fixes RHEL8 and RHEL9 BZs

  • https://bugzilla.redhat.com/show_bug.cgi?id=2129008
  • https://bugzilla.redhat.com/show_bug.cgi?id=2129846

matejak avatar Oct 12 '22 09:10 matejak

@matejak I find it difficult to review this PR.

  1. I need to reproduce the BZs to verify that the changes in this PR fix the BZs. However, I miss a kickstart that is used to reproduce this BZs. When I add the %addon org_fedora_oscap snippet from rhbz#2129008 to my kickstart, change the IPs, URLs and paths in that snippet for my local values and then start a RHEL 8.7 installation, I get "error when fetching content" in the OAA spoke in the bottom, which is probably fine, but I don't see the messages that are listed in the BZ in the /tmp/anaconda.log. I assume that I can similarly struggle to reproduce with RHEL 9.1. Therefore, please attach the kickstarts that you used to reproduce and test this BZ on both RHEL 8.7 and 9.1 to this PR. Also, please describe the steps that you performed when you tested your patch.

  2. This PR is against master branch which is on Fedora, but I don't know how to test Fedora as the linked BZs are on RHEL 8.7 and 9.1. When I try to download the patch file from this PR URL and apply it to current upstream rhel8-branch branch it doesn't apply, probably there are conflicts. I can try to resolve these locally but I don't know if this would be fine. How can I test that this PR fixes the linked RHEL BZs?

jan-cerny avatar Oct 13 '22 07:10 jan-cerny

The inspection completed: 6 updated code elements

scrutinizer-notifier avatar Oct 13 '22 12:10 scrutinizer-notifier

To clarify, this will be done after https://github.com/OpenSCAP/oscap-anaconda-addon/pull/220 will be discussed because it's a RHEL 8 variant of this PR.

jan-cerny avatar Oct 20 '22 06:10 jan-cerny

@matejak The PR #220 has been merged so this PR is now unblocked and you can start working on it.

Also, can you answer the question above about testing on Fedora? What are the steps that you have taken when testing this on Fedora?

jan-cerny avatar Nov 10 '22 10:11 jan-cerny

@matejak I'm strongly disappointed by no response.

jan-cerny avatar Apr 12 '23 07:04 jan-cerny

@matejak PING

jan-cerny avatar Jun 27 '23 06:06 jan-cerny

@matejak ping

jan-cerny avatar Nov 06 '23 07:11 jan-cerny