oscap-anaconda-addon icon indicating copy to clipboard operation
oscap-anaconda-addon copied to clipboard

Abbreviate profile descriptions based on total profile count

Open matejak opened this issue 5 years ago • 2 comments
trafficstars

Main problem with this PR:

  • It is not easily possible to expand description of a profile that you would like to see.

The displayed text is set in org_fedora_oscap/gui/spokes/oscap.py:626, but it is not HTML, so a CSS/JS trick with a clickable "More" is not applicable. The text is specified in so-called pango markup which can do nice tricks to fit a line to particular width, but it doesn't provide functionality to hide and expand long paragraphs.

matejak avatar May 28 '20 15:05 matejak

Hello @matejak! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 627:33: E127 continuation line over-indented for visual indent

pep8speaks avatar May 28 '20 15:05 pep8speaks

The inspection completed: 2 updated code elements

scrutinizer-notifier avatar May 28 '20 15:05 scrutinizer-notifier