openscap icon indicating copy to clipboard operation
openscap copied to clipboard

Compatibility with newer verison of procps

Open havardAasen opened this issue 3 years ago • 3 comments

There has been some changes with the newer (> 4.0) version of procps(-ng) library. It seems they no longer include proc/devname.h, which is needed for the files src/OVAL/probes/unix/process58_probe.c and src/OVAL/probes/unix/process_probe.c.

Not sure what's best action moving forward, politely ask procps maintainer to include the header again, or just rely on compat/dev_to_tty.c.

havardAasen avatar Nov 21 '22 22:11 havardAasen

Well, Fedora and RHEL are using compat/dev_to_tty.c without procps-ng-devel. So far I'm not aware of any problems related to that.

evgenyz avatar Nov 21 '22 23:11 evgenyz

I mean, default package configuration is not to ask for that header. Which is the config most of our users are facing.

evgenyz avatar Nov 21 '22 23:11 evgenyz

Hmmm, yes, the only reference I could find in the documentation was this. https://github.com/OpenSCAP/openscap/blob/d10c40e43e1c627912374b8fbdfa1a84967fcc92/docs/developer/developer.adoc#L156

And that's not the development package.

Could the references in the code and CMake be removed? This will likely only lead to confusion, especially with the latest release of procps that' don't even have the necessary header. Then we are forced to use compat/dev_to_tty.c regardless.

havardAasen avatar Nov 22 '22 18:11 havardAasen