OpenSAGE icon indicating copy to clipboard operation
OpenSAGE copied to clipboard

Improve AptEditor & Apt VM

Open billstark001 opened this issue 3 years ago • 4 comments

I implemented a prototype of the EA-modified ActionScript VM. The main TO-DO list includes AS DOM, built-in function implementations, script compiler, and Apt file writer.

billstark001 avatar Jul 14 '21 09:07 billstark001

Sorry for creating a pull request with so many unfinished codes. The underlying logic is still incomplete to a large extent, I plan to clean up the code after I finished mostly the resource-loading logic, built-in AS functions, and opcodes. This PR is only a draft as proposed.

billstark001 avatar Jul 14 '21 10:07 billstark001

@BillStark001 no problem, i saw this is a draft :) Just wanted to comment early, so you know we're looking at it. Also feel free to join our Discord to discuss this stuff :+1:

feliwir avatar Jul 14 '21 11:07 feliwir

Hi @BillStark001 - this is an incredible amount of work you're doing here!

I wanted to check what your plans are for this. Are you planning to have the APT Editor in a separate repository?

I'm asking because we're considering moving the existing AptEditor out of the OpenSAGE repository and into a separate repository, in order to lower the maintenance overhead for us. I want to understand what that would mean for you.

tgjones avatar Nov 10 '21 22:11 tgjones

Hi @tgjones . Thanks for your attention. I have planned to do so, but since there are so many bugs to fix and features to implement, and most of them need the modification of both AptEditor and FileFormats.Apt, the separation is of relatively low priority. But If you want to separate then you can split it in prior. I think it is okay for me to continue developing and to merge my works into yours. This PR is not the final one anyway.

billstark001 avatar Nov 13 '21 14:11 billstark001