openroberta-lab icon indicating copy to clipboard operation
openroberta-lab copied to clipboard

Issue #1331: fix server error when generating colour with user defined function

Open RaghuvirShirodkar opened this issue 2 years ago • 1 comments

Description

This PR implements the following changes:

  • update visitLightAction methods in Arduino, Mbot and Sensebox CPP visitors.
  • update tests to accommodate changes.

The relevant changes for arduino-resources repo can be found here.

Fixes #1331

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested with source code editor. Yet to be tested on the robots, hence WIP.

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] My changes generate no new warnings
  • [x] New and existing unit tests pass locally with my changes
  • [x] Any dependent changes have been merged and published in downstream modules

RaghuvirShirodkar avatar Sep 26 '22 11:09 RaghuvirShirodkar

Tested successful on Arduino Uno. Here is a sample program for testing.

RaghuvirShirodkar avatar Oct 12 '22 12:10 RaghuvirShirodkar