openrefine.org icon indicating copy to clipboard operation
openrefine.org copied to clipboard

Add admonition about Date functions now using UTC

Open thadguidry opened this issue 1 year ago • 2 comments
trafficstars

  • Fixes https://github.com/OpenRefine/OpenRefine/issues/6009

thadguidry avatar Aug 05 '24 02:08 thadguidry

Deploy Preview for openrefine-website ready!

Name Link
Latest commit ccb85b72e01e65984a9c6450461ac85d236ec214
Latest deploy log https://app.netlify.com/sites/openrefine-website/deploys/67c6b01ffdab580008d1f5c4
Deploy Preview https://deploy-preview-360--openrefine-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 05 '24 02:08 netlify[bot]

@tfmorris and @ostephens Do you think this would close that linked issue?

thadguidry avatar Aug 19 '24 01:08 thadguidry

OK, I think this is now ready for final review and merging. I've fulfilled all of Tom's suggestions:

  • moving admonition about date/time handling changes since 3.0 into only toString() section
  • clean up now() removing ISO 8601 mention and giving new examples as he suggested.

thadguidry avatar Feb 14 '25 10:02 thadguidry

@wetneb We can close the OpenRefine issue #6009 if you can review and agree with my last comment and we merge this? Looks good?

thadguidry avatar Mar 01 '25 10:03 thadguidry

@wetneb Better? I reverted that 1 note.

thadguidry avatar Mar 04 '25 07:03 thadguidry

Let's leave it under toString() , Tom had a good point that the changes he did actually fall under toString() changes anyways, so that's where any regession would be impacted the most, which is where I think his logic was going.

So let's merge please and move on to other important things.

thadguidry avatar Mar 04 '25 08:03 thadguidry