-i 0.0.0.0 not working since 3.5?

[marcadella]

Using 3.4.1 (docker run -p 3333:3333 felixlohmeier/openrefine:3.4.1), curl localhost:333 works.

Using 3.5.0, curl localhost:333 hangs. Is it because of -i 0.0.0.0 not being properly handled in 3.5.1??

[wetneb]

We did introduce some host validation logic, as you can see here: https://github.com/OpenRefine/OpenRefine/pull/3212 Perhaps the documentation could be improved, though.

[ajs6f]

This bit me. I found the issue linked to be poor documentation. I had to trial-and-error various combinations of settings to get the behavior I wanted (exposure on 0.0.0.0 for a server-hosted instance). I could not get my desired behavior to happen using refine.ini, only using the -i flag, which is inconvenient. Documentation would be appropriate, and if this change reduces the capability of refine.ini it would be as well to document that too.

[wetneb]

@ajs6f thank you for the feedback! If you feel like giving concrete suggestions of how the documentation should be improved, that might help any prospective contributor to have a go at it.

[ajs6f]

Give two use cases: single operator (localhost only), server-based install exposed on a single interface. Show example refine.ini configuration for both. If that is impossible because refine.ini can no longer be used for one case or the other, explain that and give sample CLI invocations for both cases. It would be worthwhile to include a short table with all relevant CLI flags, what they do, and how they interact.

[wetneb]

Thanks! Marking this as a good first documentation: this should be a documentation-only pull request, no code change should be required.

[digitalNomadKg]

Hello @wetneb I am outreachy applicant, can you please assign this task to me? I would like to try. Thank you

[digitalNomadKg]

@wetneb @marcadella I need your help, can you please guide to initial request, I got a bit lost and can't understand from where I should start. thanks

[wetneb]

This issue is about improving the documentation, so you should be able to simply click on the edit button of the corresponding manual page and propose your changes to the documentation.

[sherrif10]

Hello @wetneb am an outreachy participant, kindly assigne me to this issue.

[antoine2711]

Hello @wetneb am an outreachy participant, kindly assigne me to this issue.

Hi @sherrif10. This issue has already been assigned to someone (and 10 days ago, so not long). Please choose another issue, or ask the current assigned person if still working on the issue (which is probably the case since he's like you an Outreachy applicant).

Regards, Antoine

[digitalNomadKg]

@wetneb please assign task to @sherrif10

[sherrif10]

Thanks @wetneb

[sherrif10]

Hello @wetneb , @marcadella , could you point to me the areas that are not documented well. with main/docs . every documentation seems to be on point. is this somewhere you would love to see improvements.

[amyra98]

I have gone through the PR#3212 so I just need to mention why its not working in using 3.5.0 while it works for others and also note the behaviors of refine.host and refine.interface from PR#3212 for which it works and also write the changes that @ajs6f mentioned. Right? Can you please assign me this issue and tell me exactly where in the documentation I have to mention these? @wetneb

[wetneb]

First let's migrate this to the openrefine.org repository since our documentation is now stored there. I would follow the documentation outline suggested by @ajs6f indeed.