OpenRefine icon indicating copy to clipboard operation
OpenRefine copied to clipboard

Add the `dist` command to the Windows `refine.bat` file like we have for Linux `refine` script

Open thadguidry opened this issue 11 months ago • 10 comments

  • [ ] Add the dist command to the Windows refine.bat file just like we have in the Linux refine shell script.
    • [ ] We might use the command mvn -Drevision=<version> package -P windows in the dist command?
  • [ ] Allow it to take a version parameter as it does in the Linux refine shell script.
  • [ ] #7088
  • [ ] Ensure that upon starting OpenRefine that on the main Project page, that same version number is shown in the lower left About area.

thadguidry avatar Jan 09 '25 23:01 thadguidry

is anybody else working on this? I'd like to try resolving the issue

Michael-Cardentey avatar Jan 17 '25 16:01 Michael-Cardentey

You can certainly work on this subtask issue @Michael-Cardentey ! This is only to add the dist command (and help text for it). The command's execution should occur, but is not expected to complete with success, because that depends on #7088 and #6878 to eventually be completed.

thadguidry avatar Jan 18 '25 05:01 thadguidry

@Michael-Cardentey Hello again! If you are not going to work on this or lost interest, we have another contributor @shwetd19 who would like a chance to work on it. Would that be ok @Michael-Cardentey, or do you intend to finish this shortly in the next week or two?

thadguidry avatar Jan 26 '25 23:01 thadguidry

Hi @thadguidry ,

I recently started my journey to open-source and came across this issue. How do I see this is already assigned to another person but I was curious to know exactly how do you fix it and what changes did you expect to fix this issue

Not to worry, I am not going to replicate these changes and create a PR.

But Just out of curiosity asking it.

Also, it would be pretty helpful if you can help me find some issues I can work with as I see most of the issues in "Issues" tab have either already been assigned or are too old...

Thank You!

devatbosch avatar Jan 27 '25 10:01 devatbosch

I don't know how to fix otherwise I would have assigned myself to it and fixed it :-)

You might filter our issues by the label "good first issue". You might also try out OpenRefine using tutorials we have listed in our docs as well as following our technical reference on how to build OpenRefine and test it.

thadguidry avatar Jan 27 '25 22:01 thadguidry

Automatically unassigned after 45 days of inactivity.

github-actions[bot] avatar Mar 14 '25 04:03 github-actions[bot]

I would encourage you to only mark an issue as a "good first issue" if you are confident you would be able to tackle the issue yourself very easily, @thadguidry. Otherwise you might be attracting people to an issue that's difficult to solve, which might be frustrating for them.

wetneb avatar Mar 27 '25 09:03 wetneb

Hi, I'd love to contribute to this issue! May I take this on? 😄

2897robo avatar Apr 14 '25 03:04 2897robo

Given that the refine dist command doesn't work on Linux either, I think imitating its behaviour on Windows wouldn't be very useful. I would recommend to remove the "good first issue" label on this issue and encourage @2897robo to work on something else.

wetneb avatar Apr 14 '25 08:04 wetneb

I think that's a good point @wetneb. Do you know if there's a good reference for the intended behavior of refine dist? I know there's the mac_dist function in the refine script, but I'm not sure exactly what would need to happen to translate that to Linux and Windows.

SoryRawyer avatar Apr 14 '25 18:04 SoryRawyer