OpenRefine icon indicating copy to clipboard operation
OpenRefine copied to clipboard

Resizeable columns

Open wetneb opened this issue 1 year ago • 2 comments

Closes #4806. Backports #5840.

Depends on #6546, therefore marked as draft until this one is merged.

wetneb avatar Apr 24 '24 12:04 wetneb

Good catch! This was caused by some fractional widths being set, which should be fixed by d13a68a.

wetneb avatar Aug 13 '24 09:08 wetneb

Thanks for the update, but, unfortunately, it doesn't seem to have fixed the problem. The initial size of many columns is fractional, but they display fine, so I poked a little bit at the CSS. When I increased the right border from 1px to 2px, the display looks like this: Screenshot 2024-08-14 at 3 29 18 PM so the border on the "Profession" column is there, but partially occluded by something. The only other hint that I can offer is that removing width: max-content appears to fix the border rendering (but also collapses all the column widths to their default).

Screenshot 2024-08-14 at 3 32 24 PM Screenshot 2024-08-14 at 3 32 36 PM

tfmorris avatar Aug 14 '24 19:08 tfmorris

Sorry about this, I am not sure why I thought my commit had fixed it: I could indeed still reproduce the problem on my side.

After more investigation it seems that the will-change: transform CSS attribute was the culprit. I am not completely sure why it was introduced back when @lisa761 worked on infinite scrolling. I suspect it was to anticipate that the width of a column could change when scrolling, as new content would be added in the newly-fetched rows. This isn't the case here as we don't have any infinite scrolling. Also this property is meant to be added in a transitional fashion via a script rather than permanently, so I think it's safe to remove. And it seems to reliably fix the issue as far as I can tell (tested with Firefox and Chromium).

wetneb avatar Sep 11 '24 16:09 wetneb

I have expanded the resizing controls so that they also cover the column groups area

wetneb avatar Sep 28 '24 06:09 wetneb