OpenRailwayMap
OpenRailwayMap copied to clipboard
OpenRailwayMap
Polish JOSM presets
This is an initial (yet mostly complete) version of two JOSM presets (pl and pl-signals).
How should XML attributes be ordered in de.xml? In some places de.something is set before something because 'd' < 's' and in other de.something goes after something because it’s something’s translation (not to mention that there’s no clear order at all in most of the code). Cleaning it up isn’t the main point of this PR yet I’d prefer to not make it worse.
JOSM will sort the entries according to their translation if values_sort is not set, so if that is not given the order does not matter. The order of attributes to a given key doesn't matter either.
More details can be found in the JOSM wiki.
Does that tagging match what has been described in the OSM wiki? Can you please translate that page to Polish, I guess there will be the need to read about that tagging once it comes into usage.
Well, on that Wiki page, railway:signal:…:height is only set for semiautomatic signals and derail lanterns (where it has constant value of dwarf). That’s certainly not enough, for example shunting signals are commonly used in both heights, but in case of semaphores/signals that are always used in a single height, we can either set <key match="key"…/> or not set height at all.
I have had translated most of the Wiki page, but still have to rethink some parts, like the light main and combined signals. This PR is far from ready to be merged and I am a bit short on time these days, so I would prefer to add the presets in smaller steps, starting from signs and semaphores, since I think their tagging schemes are in quite good shape. I will rebase this PR on my current files once I clean them up, hopefully in September, and send other contributions in future PRs.
I'll gladly accept a MR that adds Polish translations to the elements already in de.xml, i.e. no new features but only strings.